Function-definition is not allowed here before what?

       today decided explore more in-depth servo motor. , wanted spin continuously until tell stop. , first off code:

code: [select]

#include <servo.h>

char commandtext;

servo myservo;

int angle = 0;

void setup() {

  serial.begin(9600);
  myservo.attach(9);
}

void loop() {


  if (serial.available() > 3) {
    if (serial.read(commandtext) = start) {
      start();
    }

    else if (serial.read(commandtext) = stay) {
      stay();
    }


  }
}
void start() {

  for (angle = 0; angle <= 180; angle += 1) {
    // in steps of 1 degree
    myservo.write(angle);
  }
  for (angle = 180; angle >= 0; angle -= 1) {
    myservo.write(angle);
  }
}


void stay() {
  myservo.write(angle);
}



and error message this:

code: [select]

arduino: 1.6.9 (windows 10), board: "arduino/genuino uno"

c:\program files (x86)\arduino\arduino-builder -dump-prefs -logger=machine -hardware "c:\program files (x86)\arduino\hardware" -tools "c:\program files (x86)\arduino\tools-builder" -tools "c:\program files (x86)\arduino\hardware\tools\avr" -built-in-libraries "c:\program files (x86)\arduino\libraries" -libraries "c:\users\kati\documents\arduino\libraries" -fqbn=arduino:avr:uno -ide-version=10609 -build-path "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp" -warnings=none -prefs=build.warn_data_percentage=75 -verbose "c:\users\kati\documents\arduino\spinning_wheel\spinning_wheel.ino"
c:\program files (x86)\arduino\arduino-builder -compile -logger=machine -hardware "c:\program files (x86)\arduino\hardware" -tools "c:\program files (x86)\arduino\tools-builder" -tools "c:\program files (x86)\arduino\hardware\tools\avr" -built-in-libraries "c:\program files (x86)\arduino\libraries" -libraries "c:\users\kati\documents\arduino\libraries" -fqbn=arduino:avr:uno -ide-version=10609 -build-path "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp" -warnings=none -prefs=build.warn_data_percentage=75 -verbose "c:\users\kati\documents\arduino\spinning_wheel\spinning_wheel.ino"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\sketch\spinning_wheel.ino.cpp" -o "nul"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\sketch\spinning_wheel.ino.cpp" -o "nul"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\program files (x86)\arduino\libraries\servo\src\avr\servo.cpp" -o "nul"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\program files (x86)\arduino\libraries\servo\src\sam\servo.cpp" -o "nul"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\program files (x86)\arduino\libraries\servo\src\samd\servo.cpp" -o "nul"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\sketch\spinning_wheel.ino.cpp" -o "nul"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics  -w -x c++ -e -cc -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\sketch\spinning_wheel.ino.cpp" -o "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\preproc\ctags_target_for_gcc_minus_e.cpp"
"c:\program files (x86)\arduino\tools-builder\ctags\5.8-arduino10/ctags" -u --language-force=c++ -f - --c++-kinds=svpf --fields=ksttzns --line-directives "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\preproc\ctags_target_for_gcc_minus_e.cpp"
"c:\program files (x86)\arduino\hardware\tools\avr/bin/avr-g++" -c -g -os -w -std=gnu++11 -fno-exceptions -ffunction-sections -fdata-sections -fno-threadsafe-statics -mmd -mmcu=atmega328p -df_cpu=16000000l -darduino=10609 -darduino_avr_uno -darduino_arch_avr   "-ic:\program files (x86)\arduino\hardware\arduino\avr\cores\arduino" "-ic:\program files (x86)\arduino\hardware\arduino\avr\variants\standard" "-ic:\program files (x86)\arduino\libraries\servo\src" "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\sketch\spinning_wheel.ino.cpp" -o "c:\users\kati\appdata\local\temp\build24b55523d3b89de1421336fdb871789d.tmp\sketch\spinning_wheel.ino.cpp.o"
c:\users\kati\documents\arduino\spinning_wheel\spinning_wheel.ino: in function 'void setup()':

spinning_wheel:15: error: function-definition not allowed here before '{' token

 void loop() {

             ^

spinning_wheel:46: error: expected '}' @ end of input

 */

  ^

using library servo @ version 1.1.2 in folder: c:\program files (x86)\arduino\libraries\servo
exit status 1
a function-definition not allowed here before '{' token

the part "a function-definition not allowed here before" very confusing.
note: researched no didn't answer.

so beside telling me what's mistake please explain me concept of function-definition;


edit: replies. looked through codes wrote. , looked stupid , did guys told me. autoformat.

now it's this

code: [select]


#include <servo.h>

char commandtext;

servo myservo;

int angle = 0;

void setup() {

  serial.begin(9600);
  myservo.attach(9);
}

void loop() {


  if (serial.available() > 3) {
    if (serial.read(commandtext) = start) {
      start();
    }

    else if (serial.read(commandtext) = stay) {
      stay();
    }


  }
}
void start() {

  for (angle = 0; angle <= 180; angle += 1) {
    // in steps of 1 degree
    myservo.write(pos);
  }
  for (angle = 180; angle >= 0; angle -= 1) {
    myservo.write(angle);
  }
}


void stay() {
  myservo.write(angle);
}


and got error message

 

code: [select]

using library servo @ version 1.1.2 in folder: c:\program files (x86)\arduino\libraries\servo
exit status 1
no matching function call 'hardwareserial::read(char&)
please me i'm excited project.

you missing closing '}' in setup() function. means compiler thinks trying declare function loop() within function setup() instead of after it.

there thousands of tutorials on c functions , going detail here add clutter. google friend.

Arduino Forum > Using Arduino > Programming Questions > Function-definition is not allowed here before what?

arduino